Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] adding azure_rm_containerregistrywebhook_facts #45065

Closed
wants to merge 1 commit into from
Closed

[WIP] adding azure_rm_containerregistrywebhook_facts #45065

wants to merge 1 commit into from

Conversation

zikalino
Copy link
Contributor

@zikalino zikalino commented Sep 2, 2018

SUMMARY

Adding container registry webhook functionality.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_containerregistrywebhook_facts

ANSIBLE VERSION

2.7

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Sep 2, 2018

cc @haroldwongms @nitzmahone @trstringer @xscript @yuwzho
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.7 This issue/PR affects Ansible v2.7 azure cloud module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Sep 2, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 2, 2018

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/azure_rm_containerregistrywebhook_facts/aliases:0:0: missing alias `shippable/azure/group[1-8]` or `unsupported`

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_containerregistrywebhook_facts.py:186:1: E305 expected 2 blank lines after class or function definition, found 0

The test ansible-test sanity --test validate-modules [explain] failed with 6 errors:

lib/ansible/modules/cloud/azure/azure_rm_containerregistrywebhook_facts.py:0:0: E307 version_added should be 2.8. Currently 2.5
lib/ansible/modules/cloud/azure/azure_rm_containerregistrywebhook_facts.py:0:0: E322 "append_tags" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/azure/azure_rm_containerregistrywebhook_facts.py:0:0: E322 "tags" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/azure/azure_rm_containerregistrywebhook_facts.py:0:0: E324 Value for "default" from the argument_spec (True) for "append_tags" does not match the documentation (False)
lib/ansible/modules/cloud/azure/azure_rm_containerregistrywebhook_facts.py:0:0: E325 argument_spec for "append_tags" defines type="bool" but documentation does not
lib/ansible/modules/cloud/azure/azure_rm_containerregistrywebhook_facts.py:110:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. and removed ci_verified Changes made in this PR are causing tests to fail. labels Sep 2, 2018
@ansibleazurebot ansibleazurebot mentioned this pull request Sep 3, 2018
Closed
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Sep 5, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 5, 2018

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/azure_rm_containerregistrywebhook_facts/aliases:0:0: missing alias `shippable/azure/group[1-8]` or `unsupported`

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_containerregistrywebhook_facts.py:186:1: E305 expected 2 blank lines after class or function definition, found 0

The test ansible-test sanity --test validate-modules [explain] failed with 6 errors:

lib/ansible/modules/cloud/azure/azure_rm_containerregistrywebhook_facts.py:0:0: E307 version_added should be 2.8. Currently 2.5
lib/ansible/modules/cloud/azure/azure_rm_containerregistrywebhook_facts.py:0:0: E322 "append_tags" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/azure/azure_rm_containerregistrywebhook_facts.py:0:0: E322 "tags" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/azure/azure_rm_containerregistrywebhook_facts.py:0:0: E324 Value for "default" from the argument_spec (True) for "append_tags" does not match the documentation (False)
lib/ansible/modules/cloud/azure/azure_rm_containerregistrywebhook_facts.py:0:0: E325 argument_spec for "append_tags" defines type="bool" but documentation does not
lib/ansible/modules/cloud/azure/azure_rm_containerregistrywebhook_facts.py:110:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Sep 5, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 13, 2018
@Fred-sun
Copy link
Contributor

Fred-sun commented Dec 4, 2018

kindly ping

@zikalino
Copy link
Contributor Author

will create info module in 2.9

@zikalino zikalino closed this Apr 11, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 azure ci_verified Changes made in this PR are causing tests to fail. cloud module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zikalino @ansibot @Fred-sun @bcoca